[2.12.9 Bug] Experience plg 1.7.7 > Default Information

More
6 months 4 days ago - 4 months 3 weeks ago #19027 by joomleb
Hi guys,
PHP 7.4.29 + Joomla 3.10.9 / 4.1.3 + Solidres 2.12.8 + Experience plugin 1.7.6 etc.
File …/plugins/solidres/experience/components/com_solidres/views/experience/tmpl/default_information.php

1 - Email - Line from 48 to 53
Setting Joomla "Content - Email Cloaking pluing > Mode: as linkable mailto address" the Email is not cloaked and it can be read from spam bots.
As far as I know there is a way to use the Joomla standard Content - Email Cloaking plugin: docs.joomla.org/How_to_cloak_email_addre...ink_to_email_address to Cloak the Email.
Please, Can you suggest the right code ?
Can you consider to add it on next Experience plugin release ?

2 - WhatsApp is the official name,not Whatsapp: www.whatsapp.com/
…/plugins/solidres/experience/language/en-GB/en-GB.plg_solidres_experience.ini
Line 598 - SR_EXP_WHATSAPP_LABEL="WhatsApp"
Line 599 - SR_EXP_WHATSAPP_DESC="Enter your WhatsApp account"
I add here the "fixed" language file, Are you agree ?

3 - Facebook Messenger icon (Messenger means to run on Facebook + Instagram)
Line 65 - <i class="fa fa-facebook-square"></i> >>> <i class="fab fa-facebook-messenger"></i>
I add the default_information "fixed" file for you, Are you agree ?

4 - Note: also for the other icons you are using old “fa” classes instead of the “fas / fab” Font Awesome 5 ones:
<i class="fas fa-phone"></i>
<i class="fas fa-envelope"></i>
<i class="fab fa-whatsapp"></i>
<i class="fab fa-facebook-messenger"></i>

This message has an attachment file.
Please log in or register to see it.

Last edit: 4 months 3 weeks ago by joomleb.

Please Log in or Create an account to join the conversation.

More
6 months 2 days ago #19032 by solidres
Hi,

1. At this moment there is no integration with Email Cloak plugin, please post a new feature request for it.

2 & 3. We will fix it in the next release.

4. Solidres includes its own Font Awesome 4.7.0, it is good enough, there is no rush to change to Font Awesome v5. We will use Font Awesome v5 for specific icons that do not exist in v4.

Regards,

Please Log in or Create an account to join the conversation.

More
5 months 1 week ago #19052 by joomleb
Hi guys,

1 - I opened the "Joomla Email Cloak plugin - integration" Feature Request here: www.solidres.com/forum/feature-requests-...k-plugin-integration

2 - 3 Thank, we'll stay tuned here

4 - Thanks for the explication, I took note

Please Log in or Create an account to join the conversation.

More
4 months 3 weeks ago - 4 months 3 weeks ago #19083 by joomleb
Hi guys,
PHP 7.4.30+ Joomla 3.10.10 / 4.1.4 + Solidres 2.12.9 + Experience plugin 1.7.7 etc.

1 - I made some tests, but I have not reach the goal. I'll post into the Feature Request post some useful links for you hoping you can consider this as a Security fix

2 - Fixed, thanks.

3 - Solidres basically run on a self Fontawesome 4 - Solidres includes its own Font Awesome 4.7.0: www.solidres.com/forum/report-bugs/11650...mation-fixings#19032

Fontawesome 4 does not include Messenger icon: fontawesome.com/v4/icons/
but Fontawesome 5 include the facebook-square one

To add - line 65 <i class="fa fa-facebook-square fab fa-facebook-messenger"></i> does not solve the issue, because always is shown the facebook-square icon (tested it on a fresh J4 Cassiopeia installation)

Solution
following the “Solidres > Options > General > UI Framework: Bootstrap 5 (for Joomla 4)” setting
To add the language string definitions into the file .../libraries/solidres/defines.php
- line 100 - define('SR_UI_FB_MESSENGER', 'fa fa-facebook-square');
- line 133 - define('SR_UI_FB_MESSENGER', 'fa fa-facebook-square');
- line 136 - define('SR_UI_FB_MESSENGER', 'fab fa-facebook-messenger');
- line 168 - define('SR_UI_FB_MESSENGER', 'fab fa-facebook-messenger');
To call it into the file …/plugins/solidres/experience/components/com_solidres/views/experience/tmpl/default_information.php
- line 65 - <i class="fa fa-facebook-square fab fa-facebook-messenger"></i> >>> <i class="<?php echo SR_UI_FB_MESSENGER ?>"></i>

Here the “fixed” tested files. Please, Can you confirm them ?

This message has an attachment file.
Please log in or register to see it.

Last edit: 4 months 3 weeks ago by joomleb.

Please Log in or Create an account to join the conversation.

More
4 months 2 weeks ago #19091 by solidres
Hi,

3. We will add a check for Joomla version to display the correct icon in the next release.

Regards,

Please Log in or Create an account to join the conversation.

More
4 months 2 weeks ago - 4 months 2 weeks ago #19094 by joomleb
Hi,

3 - the two fixed files I added are tested and running. Just check and add them to the next release...

5 - "Messenger" is the official name of Messenger by Meta: about.facebook.com/technologies/messenger/
two languages string should be updated:
- line 596 SR_EXP_FACEBOOK_LABEL="Facebook Messenger" >>> "Messenger"
- line 597 SR_EXP_FACEBOOK_DESC="Enter your Facebook Messenger account"
- line 666 SR_EXP_SHOW_FACEBOOK_LABEL="Show Facebook" >>> "Show Messenger"
I add here the "fixed" language file.
Do you agree ?

This message has an attachment file.
Please log in or register to see it.

Last edit: 4 months 2 weeks ago by joomleb.

Please Log in or Create an account to join the conversation.

Moderators: solidres
Powered by Kunena Forum

All the things you need to make your work easier. Did you like Solidres?